search

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

The default imaging extension changed #372

Closed thjsal closed 4 months ago

thjsal commented 6 months ago

The default imaging extension has been changed from uniform.pyx to PDT_U.pyx to avoid the need for X-PSI re-installation when computing neutron star images for different nested models. The tutorials have been updated to account for this change where necessary.

Some extensions (like the r-mode extension) are still only possible to use if re-installing X-PSI after changing the content of the local_variables.pyx file.

thjsal commented 5 months ago

As a part of this pull request, this is the tutorial that is going to be back as a page in the X-PSI documentation (in case @drannawatts wants to check):

https://github.com/xpsi-group/xpsi/blob/358-change-default-extension-for-image-plane/docs/source/Global_surface_emission.ipynb

It is very technical, but I think it could be useful (it also used to be there before X-PSI version 1.0).

thjsal commented 4 months ago

I changed to version number of this update from 2.2.1 to 2.2.2, since updates from another pull request got accepted before this one. Before merging, the tutorials updated here would be good to be re-run to show correctly that they were run using v2.2.2.