Intervals calculated appear to be incorrect

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference

Other

34 stars 21 forks source link

Intervals calculated appear to be incorrect #377

Closed DevarshiChoudhury closed 4 months ago

DevarshiChoudhury commented 4 months ago

https://github.com/xpsi-group/xpsi/blob/1deb8799bfed8f5caa0452a8822cc5166fc4268a/xpsi/PostProcessing/_corner.py#L1075

Seems like the wrong quantiles are specified for interval calculation

thjsal commented 4 months ago

I think this is not a bug. Seems to me that in these lines the idea is to calculate all the other intervals, since having compute_all_intervals=True and the 68% interval was already calculated.

DevarshiChoudhury commented 4 months ago

I see. I was wondering if it was intentional somehow, and generally, I haven't previously seen anything wrong in post-processing, but couldn't make out immediately if this was right either and thought of just raising an issue. I will close it then