xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

Likelihood does not support Everywhere #378

Closed thjsal closed 3 months ago

thjsal commented 4 months ago

Calculating likelihoods using Everywhere model does not work without customizing the Likelihood class. This is because HotRegions are referenced there in a couple of places (e.g. here https://github.com/xpsi-group/xpsi/blob/31852f05807b764c6b1553683de624fbabaec3c5/xpsi/Likelihood.py#L116). But it should be possible to make likelihood calculation independent of the surface radiation model.