search

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

`module_generator` bugfix to choose correct atmosphere extension. #379

Closed DevarshiChoudhury closed 4 months ago

thjsal commented 4 months ago

The fixes look good to me (besides the printing I commented above). I also looked at the elsewhere option in module generator (as you mentioned in the original issue), and looks like that no atmosphere selection has been implemented to that yet. So it uses always the default blackbody atmosphere. If want to fix that, then should add if condition here checking if atm_ext=Num4D or atm_ext=BB should be set (like was done for the hotregions):

https://github.com/xpsi-group/xpsi/blob/c1e870ccd1bf613b4b669dac621e4d0f278fa59a/xpsi/module_generator.py#L2058

DevarshiChoudhury commented 4 months ago

Haha, good catch. That was indeed just a debugging print statement. Let me fix that and add the elsewhere change to it too

DevarshiChoudhury commented 4 months ago

@thjsal print statement removed and option for elsewhere added. Tested it and seems to work fine