search

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

UltraNest #388

Closed MHoogkamer closed 2 months ago

MHoogkamer commented 2 months ago

UltraNest as an additional sampler

thjsal commented 2 months ago

The pull request looks good to me. I checked that it at least did not break the existing MultiNest and emcee sampling examples. Probably at some point it would be good to have an UltraNest example as well.

One thing I modified was still the try-except imports of the samplers, so that you don't need to have all the samplers installed if you just want to use one of them.

I suggest to fill some text to the Changelog (including the date), and then merge. I already updated the version numbers in those 3 files where needed.

When merging, you can do "squash and merge" if just want to have one clean commit to the main branch. Unless you think having all the small commits there is useful.