xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

Elsewhere option not working correctly since v2.2.5 of X-PSI #390

Closed thjsal closed 2 months ago

thjsal commented 2 months ago

Seems like the accretion disk upgrade in v2.2.5 broke the elsewhere option of X-PSI. It calculates stuff, but using the same input parameters, it does not give anymore those likelihoods it used to give.

I see that reason is probably around these lines:

https://github.com/xpsi-group/xpsi/blob/455aded5f865da0fe3d2017caddeb8808481fc1c/xpsi/cellmesh/integrator_for_azimuthal_invariance.pyx#L465

There seems to be a new E_electronrest input parameter (instead of the original E_prime) that probably should be there only if having the Num5D option activated. Although, even in that case I think it probably won't work correctly, since the Num5D option was not implemented to the Elsewhere class.

Solution is probably to just put the old input argument back there.