I've split cmd into seperate list elements, so spaces in path should work.
I've also attempted to print the command line which will eventually run (cmd_escaped; although we still run cmd). This is useful when trying to add additional commands or learning about XQEMU command line in general.
There's still an issue if the filename contains other special symbols like comma (,).
As this was mostly a quickfix I didn't want to touch that.
Ideally we'd escape each string individually and construct a fully functional command line, with quoted strings.
I'll create an issue about this after merge.
As xqemu/xqemu is still broken for me, this barely got any testing. I expect a proper testing and review before merge.
I've also added the executable bit to main.py so it can be run using ./main.py
(Also my text editor refuses to not do a newline at end-of-file. Sorry)
mborgerson
commented
6 years ago
I've split
cmdinto seperate list elements, so spaces in path should work. I've also attempted to print the command line which will eventually run (cmd_escaped; although we still runcmd). This is useful when trying to add additional commands or learning about XQEMU command line in general.There's still an issue if the filename contains other special symbols like comma (
,). As this was mostly a quickfix I didn't want to touch that. Ideally we'd escape each string individually and construct a fully functional command line, with quoted strings. I'll create an issue about this after merge.As xqemu/xqemu is still broken for me, this barely got any testing. I expect a proper testing and review before merge.
I've also added the executable bit to main.py so it can be run using
./main.py(Also my text editor refuses to not do a newline at end-of-file. Sorry)