JayFoxRox
commented
5 years ago I want to finish this bikeshed; I've force pushed.
- I've made order:
- KVM (most supported)
- HAXM (most fixable)
- WHPX (works for some people)
- I decided against including HVF as it's the least stable and we'd have to work on (unlikely to happen soon); we'll have to create an issue as suggested in https://github.com/xqemu/xqemu-manager/pull/41#issuecomment-463337424
kernel_irqchip=offis always appended. I don't think this will break anything- TCG is not explicitly supplied in list of accelerators (and not supplied if no-accelerator is to be used); this is closer to existing code style
- I'm still unhappy with the commit title
Despite some of these points, I intend to merge this in a couple of days.
Ideally someone on Windows / macOS should test this asap; if there's any issues with this code, please speak up as soon as possible.
I've tested this on Linux; it seems to work fine.
Continuation of #41 cause I somehow broke my branch after a small rebase to include some changes from master