search

xqemu / xqemu-manager

Simple graphical user interface to manage XQEMU
http://xqemu.com
GNU General Public License v2.0
34 stars 10 forks source link

AppVeyor link in README leads to latest build (including branches / PRs), not master #45

Closed JayFoxRox closed 5 years ago

JayFoxRox commented 5 years ago

It currently points at the opened PR.

It links to:

https://ci.appveyor.com/project/xqemu-bot/xqemu-manager

It should link to:

https://ci.appveyor.com/project/xqemu-bot/xqemu-manager?branch=master

Same issue for the badge; please consult AppVeyor docs how to fix it.

JayFoxRox commented 5 years ago

The download link isn't actually fixed - this is a security issue.

I think this is a bug in AppVeyor, so I've created a bug report at https://github.com/appveyor/ci/issues/3155

The current situation is the following:

It currently points to https://ci.appveyor.com/api/projects/xqemu-bot/xqemu-manager/artifacts/xqemu-manager.zip?branch=master

That is the same as https://ci.appveyor.com/api/projects/xqemu-bot/xqemu-manager/artifacts/xqemu-manager.zip (without ?branch=master)

Both point at the same build, which is the latest PR, not a build of master.

The link should point to https://ci.appveyor.com/api/projects/xqemu-bot/xqemu-manager/artifacts/xqemu-manager.zip?branch=master&pr=false (note the additional &pr=false)