JayFoxRox
commented
5 years ago Thanks!
However, I'm closing this one - I've opened a "competing" PR which is a bit cleaner:
- Follows our existing commit style more closely
- Uses what we already discussed for xqemu/xqemu in the past (using travis-matrix-badges.herokuapp.com for macOS / Linux differentiation)
- Orders platforms as "Windows, macOS, Linux" (largest, to smallest number of users)
- Uses GitHub auto-keyword "Closes <Issue>", so we automatically track which PR fixed which issue
I hope you learn from this feedback and consider future contributions. Your effort is still appreciated and it motivated me to create my PR :+1:
(I did not want this to become a back-and-forth over such a small change, hence the sudden takeover)
Closed.
Should solve issue https://github.com/xqemu/xqemu.com/issues/44