xqms / rosmon

ROS node launcher & monitoring daemon
Other
181 stars 47 forks source link

Wrong catch_ros include dir in certain situations #156

Open xqms opened 3 years ago

xqms commented 3 years ago

As discovered in https://github.com/AIS-Bonn/catch_ros/pull/15, we currently prefer the catch_ros headers from e.g. /opt/ros/noetic/include in favor of the (correct) ones from the current workspace.

The reason is this line: https://github.com/xqms/rosmon/blob/bc88c34c7bf96483f6ff4f9e46193cf40b27f57c/rosmon_core/CMakeLists.txt#L143

... which adds the catch_ros headers to the end of all include paths. Instead, we should use catkin's list_insert_in_workspace_order() function to correctly insert the additional include path.