Systemd-journal & syslog support

xqms / rosmon

ROS node launcher & monitoring daemon

Other

180 stars 47 forks source link

Closed xqms closed 1 year ago

xqms commented 1 year ago

Instead of writing our own log files, we send our log output to the systemd journal (or BSD-style /dev/log via syslog()).

Components of this PR:

[x] Parse log output from nodes to determine severity
[x] Systemd journal client implementation (https://systemd.io/JOURNAL_NATIVE_PROTOCOL/)
- [x] Increase SO_SNDBUF size
[x] Disable own logfile creation in nodes (see #157)

xqms commented 1 year ago

We now need to figure out if this breaks any existing rosmon applications. We have two potentially breaking changes:

Disables the default rosmon log files under /tmp. I believe that most people who care about logs use the --log PATH argument, though, which still works.
Disables the internal log file writing inside the nodes (basically, ~/.ros is now obsolete).

Need to think a bit if this can be merged into master. Any thoughts?

xqms commented 1 year ago

Ok, finally got around to working on this again. I addressed both points quite conservatively:

Goes back to the old behavior of logging to /tmp/. If you want the new logging system, you have to either pass --log=syslog or set environment variable ROSMON_SYSLOG=1.
Disables internal log file writing only for the syslog case.