Closed Rayman closed 1 year ago
The correct way to do inheritance is to have a public virtual destructor, and base classes can overwrite it if needed. This fixes compilation of rosmon with clang.
See also this rule in the C++ Core Guidelines: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-dtor-virtual
Looks good to me! Thanks :)
xqms
commented
1 year ago
The correct way to do inheritance is to have a public virtual destructor, and base classes can overwrite it if needed. This fixes compilation of rosmon with clang.
See also this rule in the C++ Core Guidelines: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-dtor-virtual