search

xquercus / load-balanced-scheduler

GNU General Public License v3.0
10 stars 9 forks source link

filtered deck does not work #5

Closed cjdduarte closed 5 years ago

cjdduarte commented 5 years ago

Today I had to anticipate the 1 day reviews and used the filtered deck functionality. I've had many cards answered, scheduled for 20 days from now. See that he has not rebalanced.

Using Anki 2.1 v2 scheduler enabled.

screenshot_1

xquercus commented 5 years ago

Thank you for the report. I'll look into this. Is there any chance you could screenshot the list of plugins you have installed and the configuration of the filtered deck?

cjdduarte commented 5 years ago

I use your addon for several weeks. I never had a problem. It works perfectly. Just today, when it was the first time I used a filtered deck, that was when it happened.

The filtered deck was created from this option: image

My addons: image

lovac42 commented 5 years ago

num_cards = self.col.db.scalar("""select count() from cards where due = ? and queue = 2""", self.today + check_ivl)

filtered decks use card.odue when rescheduling is turned on. So you end up stacking everything on one day as that is the lowest day reported.

cjdduarte commented 5 years ago

I understood, but is it possible to correct myself? Or is it outside the purpose of the addon?

xquercus commented 5 years ago

Thank you both for reporting and proposing a solution to this. I really appreciate these reports. I think this looks like a bug. That is the add-on should work in this situation. I'll try and turn around a tested fix in the next few days.

cjdduarte commented 5 years ago

Thank you.

xquercus commented 5 years ago

So here's the deal. It turns out Anki (surprisingly) doesn't call the function we patch to load balance so we don't even have the opportunity to do so. No doubt it could be implemented but it's not something I'd be interested in implementing or maintaining. More patches just increase the likelihood of introducing bugs or an incompatibility when Damien changes the scheduler code. It's surprising because normally review cards are fuzzed and hence load balanced. This seems to be an exception.

This will get documented in the README.

cjdduarte commented 5 years ago

Thank you. I'm going to open a call to Damien for him to evaluate that. This may be an Anki bug. Or not.

cjdduarte commented 5 years ago

Hi, Damien asked to technically detail the problem (function that may have the problem). Can you explain?

xquercus commented 5 years ago

Just wanted to thank you guys for fleshing this out. I'm currently going on no sleep with altitude sickness but it looks like you guys are rocking.

cjdduarte commented 5 years ago

I will close this call, because I decided not to use more filtered decks

thiswillbeyourgithub commented 4 years ago

I would be very interested in this feature, V2 scheduler won't change much for a while IMO and you can always specify up to which version of anki should your addon be working or automatically disabled.

The V2 scheduler makes filtered decks way more practical and appealing, so I think there's a growing need for load balancing with them.

Thanks for considering this. Have a nice day.