search

xquery-mode / cider-any

Evaluate any buffer in cider – Replaced by Oook
0 stars 1 forks source link

cider-uruk-any fails to work with non-nil *print-length* or *print-level* #11

Closed hanshuebner closed 7 years ago

hanshuebner commented 8 years ago

If one has non-standard settings for *print-length* or *print-level*, cider-uruk-any basically fails to work. I'm not actually sure if this can be fixed locally - Is the normal repl printing used to get the results from uruk? If that is the case, then the behavior would be hard to fix because one can't re-bind the variables that the repl has bound. If the printing is done separately, then (binding [*print-length* nil *print-level* nil] ...) should do.

proofit404 commented 7 years ago

Cider any doesn't use any print output for its work. It built on top of network handler system provided by cider itself. I try to reproduce this issue on some result sequences. It works as expected so far.

I assign this config variables inside already running repl. May be this isn't a proper way to reproduce it.

Can you describe exact steps you done before cider-any stops working? How did you configure this parameters?

hanshuebner commented 7 years ago

@m-g-r will produce a reproduction case, if any...

proofit404 commented 7 years ago

@hanshuebner Do you have this problem persistently?

hanshuebner commented 7 years ago

I have removed the print-length and print-level settings from my profiles.clj for now, but I'm not currently working on this so I'm passing the ball to @m-g-r

proofit404 commented 7 years ago

I can confirm this bug.

If execution of xquery produce collection bigger then `print-length, we'll totally fail.

Will see if I can workaround this.

proofit404 commented 7 years ago

Looks like I fix it. Please check print-length-fix branch.

Also notice that error buffer doesn't pops up any more - I will fix this in the error-buffer branch (related to #13 issue) and then merge both branches at the same time.

hanshuebner commented 7 years ago

Thanks for taking care of this! Please merge whenever you have time.

On Fri, Oct 14, 2016 at 3:51 AM, Malyshev Artem notifications@github.com wrote:

Looks like I fix it. Please check print-length-fix branch.

Also notice that error buffer doesn't pops up any more - I will fix this in the error-buffer branch (related to #13 https://github.com/xquery-mode/cider-any/issues/13 issue) and then merge both branches at the same time.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xquery-mode/cider-any/issues/11#issuecomment-253689602, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGozyoUyPPvatpn_D1GlHdzB3fmJDanks5qzuA0gaJpZM4J7irv .

LambdaWerk GmbH Oranienburger Straße 87/89 10178 Berlin Phone: +49 30 555 7335 0 Fax: +49 30 555 7335 99

HRB 169991 B Amtsgericht Charlottenburg USt-ID: DE301399951 Geschäftsführer: Hans Hübner

http://lambdawerk.com/

proofit404 commented 7 years ago

Done.

m-g-r commented 7 years ago

Cool, thanks! I can confirm it works also for me in previously non-working cases.