search

xquery-mode / cider-any

Evaluate any buffer in cider – Replaced by Oook
0 stars 1 forks source link

support empty results #7

Closed m-g-r closed 8 years ago

m-g-r commented 8 years ago

Hi, cool thing! I noticed that it is not supported that an xquery might have an empty result (which is perfectly ok, if you do something like xdmp:document-load in MarkLogic).

In cider-any-uruk I get: error in process filter: Wrong type argument: char-or-string-p, nil

Bye Max

m-g-r commented 8 years ago

Trivial test case: for $foo in () return $foo

proofit404 commented 8 years ago

Thanks! Will fix ASAP.

m-g-r commented 8 years ago

Thanks, Artem! That'd be great.

proofit404 commented 8 years ago

Fixed in the callback-chain branch.

m-g-r commented 8 years ago

Cool, I cherry-picked it and it works nicely.

I suggest to rephrase the message "Evaluation completes with on result". You mean "without", right? ML says: "your query returned an empty sequence". I think something like that is more correct. An empty result is also a result.

proofit404 commented 8 years ago

I've fix this report message according to your recommendations.

m-g-r commented 8 years ago

Thank you.

proofit404 commented 8 years ago

Merged into master.