search

xragua / xraybinaryorbit

A Python Package for Analyzing Orbital Modulations in X-ray Binaries
https://xragua.github.io/xraybinaryorbit/
MIT License
2 stars 1 forks source link

Suggestion: repo cleanup #1

Closed matteobachetti closed 1 month ago

matteobachetti commented 2 months ago

In general, directories like __pycache__, build or *egg-info* should not be part of the shared code, as well as .DS_STORE files and such

xragua commented 1 month ago

Ok, I'll remove them, thanks!

warrickball commented 1 month ago

If you've made these changes (which at a glance I think you have), you may want to close this issue.

If possible, don't forget to tag the JOSS review with openjournals/joss-reviews#7220 so that this activity is linked there and easier to find.

But thanks! This is a perfectly reasonable way to proceed with the review.

xragua commented 1 month ago

@openjournals/joss-reviews/issues/7220, @matteobachetti ,@warrickball I close this issue as is already solved. Thank you!

matteobachetti commented 1 month ago

As of now, there is still another pycache directory left, plus the dist directory which is also not usually shared