search

xraypy / feff85exafs

Feff8L: Open Source theoretical EXAFS fitting standards
Other
15 stars 7 forks source link

need to get rid of ".bin" extensions #7

Closed newville closed 9 years ago

newville commented 10 years ago

Many of the temporary files from feff use the ".bin" extension to denote the "binary-data-ness" of the contents. This should be replaced.

First, the data shouldn't be raw fortran binary, as its not portable. The PAD library might still be useful, or perhaps something like hdf5 should be used.

In any event, the ".bin" extension is a pain in and of itself because it gives a stupid false-positive for many spam filters. Though mostly serving to underscore the poor quality of spam filters that rely on advertised file extensions instead of actual file contents, the ".bin" extension is generally perceived as poison and should be replaced.

bruceravel commented 10 years ago

I completely agree. Seems scary, though, to make this change before we have some kind of unit testing in place.

newville commented 10 years ago

just raising the issue now so we don't forget.

On Tue, Jun 24, 2014 at 1:04 PM, Bruce Ravel notifications@github.com wrote:

I completely agree. Seems scary, though, to make this change before we have some kind of unit testing in place.

— Reply to this email directly or view it on GitHub https://github.com/xraypy/feff85exafs/issues/7#issuecomment-47007586.

--Matt Newville 630-252-0431

bruceravel commented 9 years ago

Addressed in 500b84a6ddc134aa418da2556bc2641b1fca4a94

Changed .bin to .pad through the entire code base