search

xraypy / xraylarch

Larch: Applications and Python Library for Data Analysis of X-ray Absorption Spectroscopy (XAS, XANES, XAFS, EXAFS), X-ray Fluorescence (XRF) Spectroscopy and Imaging, and more.
https://xraypy.github.io/xraylarch
Other
133 stars 64 forks source link

No 'whiteline' argument in mback #423

Closed rachelelim closed 7 months ago

rachelelim commented 1 year ago

According to the documentation 13.2.4, mback should have a kwarg 'whiteline' that excludes a region around the white line when doing the fitting. I looked at mback.py file under xafs, and it looks like that argument doesn't exist

newville commented 1 year ago

@rachelelim. Oh, thanks! I don't recall what changed, but I'll look into that...

gnzng commented 1 year ago

Just had a quick look via blame, whiteline was replaced/deleted by commit https://github.com/xraypy/xraylarch/commit/f6d01f22855090f6e722e40848c7c80a1a27902e

newville commented 1 year ago

@gnzng Thanks Damian, yeah I sort of think the whiteline option never really worked well (or maybe "in a way that I understood"). I was trying to figure that out again, but I think @rachelelim's proposed change to the documentation might be the most sensible thing to do: match the actual behavior.

But if either of you has a strong opinion on how to improve this (or maybe some other idea for working better in the presence of a strong white line), I'd be happy to do so. Thanks!