search

xraypy / xraylarch

Larch: Applications and Python Library for Data Analysis of X-ray Absorption Spectroscopy (XAS, XANES, XAFS, EXAFS), X-ray Fluorescence (XRF) Spectroscopy and Imaging, and more.
https://xraypy.github.io/xraylarch
Other
127 stars 62 forks source link

Typo in install instructions? #512

Closed Nothinel closed 2 months ago

Nothinel commented 2 months ago

https://github.com/xraypy/xraylarch/blob/ae6ed7961ecf84a16bd5611fb9c5cc1cc5cecde6/doc/installation.rst?plain=1#L251

Is it possible that the above mentioned line is missing "conda-forge" after the -c flag?

mamba install -y -c conda-forge scikit-image scikit-learn pycifrw plotly fabio pyfai

works while 

mamba install -y -c scikit-image scikit-learn pycifrw plotly fabio pyfai

fails.

newville commented 2 months ago

@Nothinel thanks!

maurov commented 2 months ago

Fixed by 818f128e2ab8fe8e3feae7aa0d2eccc722fd2d1c (@newville thanks!)

By the way, the current Conda package for Larch works very well, so one could simply do mamba install -yc conda-forge xraylarch instead of installing first the dependencies.