search

xraypy / xraylarch

Larch: Applications and Python Library for Data Analysis of X-ray Absorption Spectroscopy (XAS, XANES, XAFS, EXAFS), X-ray Fluorescence (XRF) Spectroscopy and Imaging, and more.
https://xraypy.github.io/xraylarch
MIT License
138 stars 68 forks source link

PCA model does not save (0.9.80) #522

Closed mrvejar closed 1 month ago

mrvejar commented 4 months ago

Under the PCA tab, selcted "Save PCA Model" after building a PCA model. Status bar at the bottom of GUI reads that the .pcamod file was saved, but the actual file is not stored anywhere, i.e. does not save.

newville commented 4 months ago

@mrvejar Sorry for the trouble. I will fix this soon. I am hoping to push out 0.9.79 this week, but keep finding buglets!

mrvejar commented 3 months ago

I have encountered this issue where the PCA model (.pcamod file) is not saved in Larch version 0.9.80

newville commented 3 months ago

@mrvejar Oh, I thought we fixed that... I'll take a look (hopefully this week!).

newville commented 3 months ago

@mrvejar This works for me, in at least one example. Can you give more details or provide a project file?

mrvejar commented 3 months ago

@newville Thank you so much for checking out the issue. I am attaching a screenshot where the status at the bottom of the Larix GUI says that the PCA model file has been saved, however, the file is not saved/written in the destination folder, or in any of the Larch folders (at least as far as I can tell). I am attaching here .proj file as well. image Representative XANES spots_trimmed_norm_2024-08-09_1237.zip

newville commented 3 months ago

@mrvejar Thanks and sorry for the trouble. I can reproduce this on Windows. A fix is in progress....

mrvejar commented 3 months ago

No trouble at all, and many thanks to you @newville !