search

xraypy / xraylarch

Larch: Applications and Python Library for Data Analysis of X-ray Absorption Spectroscopy (XAS, XANES, XAFS, EXAFS), X-ray Fluorescence (XRF) Spectroscopy and Imaging, and more.
https://xraypy.github.io/xraylarch
MIT License
138 stars 68 forks source link

Launching larch in server_mode with a specified port is broken #535

Open jacobfilik opened 2 weeks ago

jacobfilik commented 2 weeks ago

This breaks running Athena with the Larch backend.

In the run_larch() method in apps.py, I think the _action='storetrue' flag causes the port number to be translated to True, which then is evaluated as integer 1, which is not good.

Probably an easy fix (might just want to add a specific action to the tuple describing the input args). I could try and put together a PR if it would be useful.

newville commented 2 weeks ago

@jacobfilik ah, sorry for that. I'll try to fix this today.