xremap / nix-flake

MIT License
43 stars 11 forks source link

Added link to "Systemwide example with X..." example config #66

Closed Tygo-van-den-Hurk closed 5 months ago

Tygo-van-den-Hurk commented 5 months ago

Added link to "Systemwide example with X..." example config

This is because this way, it's easier to find the information you are looking for. Without this link, it can be confusing if you mean an example within this repository, or one of the examples in the main repository (https://github.com/xremap/xremap/).

This way, users can immediately find the configuration you're referring to by following the link.

VTimofeenko commented 5 months ago

Thanks for the PR! Looks like <details> combined with header make the triangle button appear before the header which is a bit weird:

image

I think it would be better to add a header outside of <details> and have the summary like "Expand code":

image

  ## Systemwide example with X feature for application-specific remaps 
<details>
  <summary>
  Expand code

  </summary>

  ```nix
  # flake.nix
Tygo-van-den-Hurk commented 5 months ago

Oh that’s odd..? I didn’t have that when I was looking on my GitHub.

However I like your solution much better to be honest! I have time to update my PR tomorrow!

VTimofeenko commented 5 months ago

Hm. That is odd indeed, after checking your fork I can see what I'd expect happenning:

image

VTimofeenko commented 5 months ago

Looks good after merging. Thanks for the PR!

Tygo-van-den-Hurk commented 5 months ago

Ah cool, cheers!