search

xresloader / upload-to-github-release

MIT License
53 stars 12 forks source link

1.3.8 is not working as intended for draft/prerelease #41

Closed RadxaYuntian closed 1 year ago

RadxaYuntian commented 1 year ago

Create empty non draft prerelease first. https://github.com/RadxaYuntian/upload-to-github-release/commit/5726e7219f5ac39acf13c0e7cbcdd3109c0be067: prerelease become draft https://github.com/RadxaYuntian/upload-to-github-release/commit/52c25db546343c9cd600ba50b5e9dc505ab5a2db: prerelease become release

owent commented 1 year ago

You should put xresloader/upload-to-github-release just after softprops/action-gh-release but in the same job. Or xresloader/upload-to-github-release may run before softprops/action-gh-release. xresloader/upload-to-github-release will not change these options only when update a existed release, or it will create a new release with default options(which means draft and prerelease are both false).

RadxaYuntian commented 1 year ago

You should put xresloader/upload-to-github-release just after softprops/action-gh-release but in the same job. Or xresloader/upload-to-github-release may run before softprops/action-gh-release.

I have set up needs so upload-to-github-release always run after action-gh-release is done.

RadxaYuntian commented 1 year ago

I have created a new workflow according to what you said, and this one changed prerelease to draft as well: image

owent commented 1 year ago

Thanks and it's fixed in v1.3.9 now. I have create a test at https://github.com/xresloader/upload-to-github-release-test/blob/main/.github/workflows/release.yml

RadxaYuntian commented 1 year ago

Confirmed working on my 2 test cases.