xresloader / upload-to-github-release

MIT License
53 stars 12 forks source link

File upload not found #45

Closed TheMaverickProgrammer closed 1 year ago

TheMaverickProgrammer commented 1 year ago

The issue #44 was preemptively closed without much testing. The newest version changes the drive slash only I think? And it still fails:

image

owent commented 1 year ago

The slash problem is tested in https://github.com/xresloader/upload-to-github-release-test/actions/runs/4150466015. I will check if there is any other problem. Thanks.

TheMaverickProgrammer commented 1 year ago

https://github.com/xresloader/upload-to-github-release-test/actions/runs/4150466015/workflow

The test image is on ubuntu. Try it on windows too.

owent commented 1 year ago

@TheMaverickProgrammer This problem should be fixed now, we have test it in https://github.com/xresloader/upload-to-github-release-test/actions/runs/4155119464 and the release is here (https://github.com/xresloader/upload-to-github-release-test/releases/tag/main-79ccc08b).

Could you please test v1 branch if you have time? I will raise another PR later if v1 branch can solve your case.

TheMaverickProgrammer commented 1 year ago

I'll try your branch today.

TheMaverickProgrammer commented 1 year ago

@owent How am I supposed to test? I've tried @v1, the commit hash directly (which github says doesn't support), and the release tag name:

image

image

owent commented 1 year ago

@owent How am I supposed to test? I've tried @v1, the commit hash directly (which github says doesn't support), and the release tag name:

image

image

Please just use xresloader/upload-to-github-release@v1.

TheMaverickProgrammer commented 1 year ago

Ok I'll try that.

TheMaverickProgrammer commented 1 year ago

image It works! Thank you so much!

TheMaverickProgrammer commented 1 year ago

image Proof

owent commented 1 year ago

Thanks and it's published in v1.3.11 .