Closed enumag closed 5 months ago
Good point and thanks.
I'm no JS expert but probably you need to use something like this: https://www.geeksforgeeks.org/node-js-fs-createreadstream-method/
I'm no JS expert but probably you need to use something like this: https://www.geeksforgeeks.org/node-js-fs-createreadstream-method/
GitHub's APIs do not accept read stream as data parameter. I will try to use @file_path
to see if it will use stream internally.
Ouch... that would be rather nasty if Octokit itself requires the data to be loaded in memory. 😳 I hope it's not the case.
I have raise #55 to try to use @file_path
to upload file. But I have no repo which can be used to test a large asset file.
Could you please try v1
branch or main
branch to see if it work?
It doesn't work. The action succeeded and seemingly did actually upload the files however the files are just a few bytes large and contain the path to the file in the worker rather than the correct content.
Thanks, I will try to find another way to fix this problem later.
This issue was marked as stale due to lack of activity.
Hi, I checked your source code and found this line:
https://github.com/xresloader/upload-to-github-release/blob/8e0ffc2bf70a36035a8b5479d0903041cb11423f/src/index.ts#L721C37-L721C49
Releases can contain several large files so this way the runner can easily run out of memory and crash.
I found this while looking for alternatives when I discovered the same issue in another similar tool.