xresloader / upload-to-github-release

MIT License
52 stars 10 forks source link

default_release_body/_path #63

Closed Mikk155 closed 2 months ago

Mikk155 commented 3 months ago

default_release_body doesn't seems to update the body when the target is an existing release.

default_release_body_path doesn't seems to propertly work unless i am missing something:

default_release_body_path: CHANGELOG.md

Wich CHANGELOG.md is on the root folder

owent commented 3 months ago

This option is used to create release, not update it. We usually only want to update assets without change anything of a existed release.

Mikk155 commented 3 months ago

Makes sense, still if a boolean is made for changing that behaviour.

Let's say i specify a path to a changelog.md that is constantly changing from my commits.

I want the whole content of that markdown to be placed on the release.

Still i do understand this is something that a small group of people would do use but it would a cool variable to have

owent commented 2 months ago

Maybe we can use a new configure (such as update_release_body_path) to always update the body.

Mikk155 commented 2 months ago

sounds fine for my needs, if another variable can be added as well i'd suggest update_release_body_append boolean

owent commented 2 months ago

update_release_body, update_release_body_path and update_release_body_append are available in v1.6.0 now.