xricson / gitiles

Automatically exported from code.google.com/p/gitiles
0 stars 0 forks source link

"mvn jetty:run" needs to be run from gitiles-war dir (?) #13

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
> What steps will reproduce the problem?
1. git clone https://gerrit.googlesource.com/gitiles && cd gitiles
2. Run "mvn package jetty:run"
3. Visit http://127.0.0.1:8080 in a browser

> What is the expected output? What do you see instead?

The browser shows that Jetty hasn't correctly initialized the war file.

Running "mvn jetty:run" in the gitiles-war directory works (more).  The path to 
the defaultsDescriptor in the root pom.xml must be changed to remove the 
gitiles-war/ prefix.  It then complains about not being configured (baseUrl 
etc), but if you put in some stub values the app then starts up.

I still have a few problems though even after this (e.g. the /+static/ path is 
giving 404s); I'm not sure if this is because the workaround broke other 
things...

What's the right way to launch the war?

Original issue reported on code.google.com by jus...@fathomdb.com on 15 Nov 2012 at 2:53

GoogleCodeExporter commented 8 years ago
I'm working on killing jetty-maven-plugin with fire and replacing it with a 
"dev mode" using embedded jetty:
https://gerrit-review.googlesource.com/40463

So in the near future the right way to run gitiles for development or other 
quick purposes will be to run gitiles-dev-$VERSION.jar rather than running it 
through Maven.

As for dropping the war into your own servlet container for a production type 
environment, it should still be supported, but honestly I don't have a lot of 
experience with that kind of thing and might need to get others' input on that.

Original comment by dborowitz@google.com on 18 Dec 2012 at 6:45

GoogleCodeExporter commented 8 years ago

Original comment by dborowitz@google.com on 23 Dec 2012 at 8:57