search

xricson / gitiles

Automatically exported from code.google.com/p/gitiles
0 stars 0 forks source link

Blame view doesn't have line numbers #45

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
ex.

https://chromium.googlesource.com/chromium/blink.git/+blame/87e70381aca484f1700e
a23e72f5adc78dc4581c/Source/core/inspector/InspectorPageAgent.cpp

compared to

https://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorPageA
gent.cpp?annotate=172074

Line numbers are really important, this makes dealing with stack traces at 
specific revisions very difficult.

Original issue reported on code.google.com by esprehn@chromium.org on 21 Apr 2014 at 9:42

GoogleCodeExporter commented 8 years ago 
Line numbers used to be provided by prettify. I turned off prettify because it 
was slowing down rendering, even compared to prettify without blame. But I 
think I found the cause of that issue so we can turn prettify back on.

If I'm wrong and performance is still poor, we'll have to consider alternatives 
(client and/or server-side) for line numbers. I agree this feature is important.

Original comment by dborowitz@google.com on 21 Apr 2014 at 9:51

GoogleCodeExporter commented 8 years ago 
the blame view seems to have line numbers now.

Original comment by david.pu...@sonymobile.com on 24 Aug 2015 at 2:57