xrmx / bootchart

merge of bootchart-collector and pybootchartgui
GNU General Public License v2.0
233 stars 88 forks source link

pybootchartgui tests fail, still use instead obsolete ParserState() #26

Closed hyei closed 12 years ago

hyei commented 13 years ago

The pybootchartgui unit tests all fail mostly because it hasn't been rewritten to remove calls to ParserState(), and use the Trace() instead.

xrmx commented 13 years ago

Yeah, they are broken since a few, will fix.

xrmx commented 13 years ago

Fixed all the errors in git, still a couple of failures in process tree tests. Will try to figure out what's wrong.

jlec commented 12 years ago

Any progress here?

xrmx commented 12 years ago

AFAIR the issue here is than we can't recycle the same ProcessTree output when doing the tests. So it should not matter on real world usage. I agree that broken tests are a lame thing to have. Any help is appreciated :)

jlec commented 12 years ago

I just packed this one for gentoo Linux and our QA team likes to run the testsuites. This is the actual error:

Testing pybootchartgui/tests/process_tree_test.py...

F.F...

FAIL: testBuild (main.TestProcessTree)

Traceback (most recent call last): File "pybootchartgui/tests/process_tree_test.py", line 48, in testBuild self.checkAgainstJavaExtract(self.mk_fname('extract.processtree.1.log'), process_tree) File "pybootchartgui/tests/process_treetest.py", line 42, in checkAgainstJavaExtract self.assert(long(tokens[3]) - 10 * actual.duration < 5, "duration") AssertionError: duration

FAIL: testMergeLogger (main.TestProcessTree)

Traceback (most recent call last): File "pybootchartgui/tests/process_tree_test.py", line 53, in testMergeLogger self.checkAgainstJavaExtract(self.mk_fname('extract.processtree.2.log'), process_tree) File "pybootchartgui/tests/process_treetest.py", line 42, in checkAgainstJavaExtract self.assert(long(tokens[3]) - 10 * actual.duration < 5, "duration") AssertionError: duration


xrmx commented 12 years ago

Should be fixed in 132dec8ad0a936b6ddfa73a10fd8fb9a3ca36f81, planned point release.