search

xrmx / bootchart

merge of bootchart-collector and pybootchartgui
GNU General Public License v2.0
236 stars 88 forks source link

Tweak for command line default path(s). #31

Closed walkabouting closed 12 years ago

walkabouting commented 12 years ago

Add /var/log/bootchart/ to the defaults, when no path given at command line.

At least one distribution decided to move things into /var/log/bootchart/* and forgot to test the command line afterwards! For those distributions, this code change should allow them to work properly. Hopefully, no one else could be negatively impacted by the change.

xrmx commented 12 years ago

Thanks for the submission. Which distribution are we talking about? I'd like to double check their changes because i think that they should ship the patch if they change paths.

walkabouting commented 12 years ago

My apologies for the delay in responding here.

Ubuntu 11.* seems to be using /var/log/bootchart/ for data.

I assumed bootchart at the command line (no path argument) should look in /var/log/bootchart/. Perhaps I am wrong? Just now, I noticed that the patch will result in the entire directory being (re)processed (when using bootchart at the command line). Perhaps a better patch would add detection for processed data (avoid reprocessing), latest data (only process the latest data if there is a directory full of old data), etc?

xrmx commented 12 years ago

If you are using the packages from ubuntu you are not using this code, ubuntu is shipping its own version of the collector and an old version of pybootchartgui from google code. Is this the case?

xrmx commented 12 years ago

Closing this, no work is needed on our side.