Cleanup code

[again4you]

Dear Michael Meeks

This patch set are aimed to clean up the code of 'bootchart-collector' that is written in C language. In order to do that, I add log() & assert() functions that supports the DEBUG option. I also make both likely() and unlikely() macros for branch predict optimization. IMHO, this work would improve performance since gcc compiler speculates correctly whether the branch taken or not. As you already know, this technique is wildly used in Linux Kernel or Embedded system field.

Detailed items are as below.

• Bug fix: Remove misused unlink() function
• Move helper macros to macro.h file
• Clean up warning messages when compiling
• Add likely() and unlikely() macros
• Add detailed log() and assert() functions

[xrmx]

Not a big fan of the likely / unlikely and log macros, but the bugfix looks correct and the compiling warning looks good too. Personally i'd just cherry pick that. Michael?

[mmeeks]

On Fri, 2013-05-31 at 10:31 -0700, Riccardo Magliocchetti wrote:

Not a big fan of the likely / unlikely and log macros, but the bugfix looks correct and the compiling warning looks good too. Personally i'd just cherry pick that. Michael?

Yep - it is only worth optimising some super-inner-loop with likely /

unlikely - I'd ~never do that unless a profile showed me some real win; otherwise - go for it :-)

ATB,

    Michael.

michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot

[xrmx]

I cherry picked e163992 , e2dcee2 , dd0a4ca . Thanks Sangjung!