fix bootchart-collector on kernels with CONFIG_TASKSTATS=n

xrmx / bootchart

merge of bootchart-collector and pybootchartgui

GNU General Public License v2.0

234 stars 88 forks source link

fix bootchart-collector on kernels with CONFIG_TASKSTATS=n #54

Closed Max-E closed 10 years ago

Max-E commented 10 years ago

The function get_family_id was supposed to return a negative number to indicate that the taskstats API was unavailable. However, its return value was stored to an unsigned variable, so this condition went undetected in the code.

It now returns zero instead of a negative number, and this appears to fix the problem.

Signed-off-by: Max Eliaser max.eliaser@intel.com

This appears to resolve issue #53.

mmeeks commented 10 years ago

Looks lovely to me - thanks for the fix ! =) and yes, I'd struggled with no TASKSTATS in the past and not got to the bottom of it - thanks for that.

Max-E commented 10 years ago

Do you currently have a feel for when the next stable version of bootchart2 will be tagged? I'd like to know if it's worth the trouble for me to backport this to 0.14.5.

xrmx commented 10 years ago

Max, I'll cut a new release later today. Thanks! UPDATE: released 0.14.6

Max-E commented 10 years ago

Awesome, thanks!