xrmx / bootchart

merge of bootchart-collector and pybootchartgui
GNU General Public License v2.0
234 stars 88 forks source link

tmpfs folder in /lib folder #62

Open tele1 opened 9 years ago

tele1 commented 9 years ago

/lib/bootchart/tmpfs

This not good place for tmpfs, REALLY :-) Maybe /tmp folder will better than /lib ?

When I builded rpm package, tmpfs folder not exist. I added this hand to spec file

%make_install

this fix bug with not installed folder

install -m 755 -d %{buildroot}/lib/bootchart/tmpfs

PS: debug option for bootchart will be great idea ;-)

xrmx commented 9 years ago

/lib may be not the best but served us well during this years :) make install should already take care of creating the dir, so possibly something is wrong in the packaging perhaps? What do you mean by debug option?

tele1 commented 9 years ago

What do optflags macro:

$ rpm --eval=%{optflags} -O2 -pipe -Wformat -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables

In line 123 you have _makeinstall

%make_install

What do %make_install macro:

$ rpm --eval=%make_install make install DESTDIR=/home/gg/src/rpm/BUILDROOT/%{name}-%{version}-%{release}.i386

     In line 130 you see this folder is created but not have permission.

When I installed bootchart hand , this also not have permission, but I checked folder in file manager and it have , so maybe when I installed hand "make install" copied permission from above command to this folder.

But when I tried build package this folder not exist. From 146 to 166 line I see scripts, maybe this scripts removed this folder, but I don't know why.

xrmx commented 9 years ago

The rpm specfile you are mentioning is not made by us. It's a distro specific one so you should resolve with whome has actually packaged bootchart2 for your distro.

tele1 commented 9 years ago

rpm spec file is very similar for all distro, the difference is on version rpm, and sometimes in macro if is build new, and name dependencies. If this is not problem with rpm in OpenSuse and Fedora maybe this is problem version rpm. Or maybe what you said It's a distro specific because use own also scripts. (if this is true)

xrmx commented 9 years ago

i mean that we cannot fix something that is not in this repository :) make install properly creates the directory, so the issue is not in our build scripts but in the packaging.

tele1 commented 9 years ago

This is my spec file bootchart2: http://wklej.org/id/1654216/

I not added only script which will add bootchart2 to Grub1 and Grub2 because I don't know how.

Use " e " key when Grub started and add option hand is more easy.

xrmx commented 9 years ago

I don't know anything about rpm but google found this opensuse factory rpm you can use as reference: ftp://www.rpmfind.net/linux/RPM/opensuse/factory/aarch64/aarch64/bootchart-2.0.14.7-1.1.aarch64.html src rpm link: http://download.opensuse.org/ports/aarch64/source/factory/repo/oss/suse/src/bootchart-2.0.14.7-1.1.src.rpm

tele1 commented 9 years ago

This macro

%service_add_pre looks like systemd command/ macro (I'm not sure) , Fedora also use systemd. PCLinuxOS can use only Grub1 , Grub2 and maybe LILO, but not systemd. I tried find grub command how add bootchart2 to Grub but maybe not exist.

xrmx commented 9 years ago

The rules for grub should be both in the man page and in the README