search

xrmx / bootchart

merge of bootchart-collector and pybootchartgui
GNU General Public License v2.0
233 stars 87 forks source link

Number of tokens in diskstats varies depending on kernel version #87

Closed gramound closed 3 years ago

gramound commented 3 years ago

The parsing of the disk stats isn't working for new kernels due to is_relevant_line expecting 14 tokens. See kernel doc below.

https://github.com/xrmx/bootchart/blob/868a2afab9da34f32c007d773b77253c93104636/pybootchartgui/parsing.py#L458

https://www.kernel.org/doc/Documentation/ABI/testing/procfs-diskstats

mmeeks commented 3 years ago

Good catch, want to submit a simple back-compatible pull request =) would be great to have your contribution.