search

xrobin / pROC

Display and analyze ROC curves in R and S+
https://cran.r-project.org/web/packages/pROC/
GNU General Public License v3.0
118 stars 31 forks source link

Also skip if missing ggplot2 #114

Closed MichaelChirico closed 1 year ago

MichaelChirico commented 1 year ago

ggplot2 is only Suggests for vdiffr, so skipping for vdiffr is not sufficient to ensure doppelganger tests run.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (e88ad74) 85.65% compared to head (ea93680) 85.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #114 +/- ## =========================================== - Coverage 85.65% 85.63% -0.03% =========================================== Files 33 33 Lines 3569 3569 =========================================== - Hits 3057 3056 -1 - Misses 512 513 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/xrobin/pROC/pull/114/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Xavier+Robin)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

xrobin commented 1 year ago

Hi Michael, thanks a lot for the pull request!

That's a good catch. Tests should definitely not fail if ggplot2 is unavailable.

I guess technically some of the tests using this function only use the base plot engine, but that should be good enough.

I'll merge it asap.