search

xrobin / pROC

Display and analyze ROC curves in R and S+
https://cran.r-project.org/web/packages/pROC/
GNU General Public License v3.0
121 stars 31 forks source link

Forthcoming release of ggplot2 and pROC #53

Closed paleolimbot closed 5 years ago

paleolimbot commented 5 years ago

We are contacting you because you are the maintainer of pROC, which imports ggplot2 and uses vdiffr to manage visual test cases. The upcoming release of ggplot2 includes several improvements to plot rendering, including the ability to specify lineend and linejoin in geom_rect() and geom_tile(), and improved rendering of text. These improvements will result in subtle changes to your vdiffr dopplegangers when the new version is released.

Because vdiffr test cases do not run on CRAN by default, your CRAN checks will still pass. However, we suggest updating your visual test cases with the new version of ggplot2 as soon as possible to avoid confusion. You can install the development version of ggplot2 using remotes::install_github("tidyverse/ggplot2").

If you have any questions, let me know!

paleolimbot commented 5 years ago

We're hoping to release it in the next week or two! We don't know the exact timing because the submission to CRAN takes time and may result in more changes.

xrobin commented 5 years ago

I ran vdiffr::manage_cases() with ggplot 3.1.1.9000 and vdiffr found no difference. I will keep an eye open in the next few weeks if any test starts to fail. Thanks!

xrobin commented 5 years ago

CI failed as ggplot2 was updated now. It's a good positive test to ensure the tests are run. Fixed now and merged into master.