search

xrootd / xrootd

The XRootD central repository https://my.cdash.org/index.php?project=XRootD
http://xrootd.org
Other
151 stars 150 forks source link

XrdCl:: zip :: pgread :: buffer is too small #1732

Closed adriansev closed 2 years ago

adriansev commented 2 years ago

Hi @simonmichal ! we have another problem related to copy operation of a zip member: from dump log:

[2022-07-03 15:06:20.135248 +0300][Error  ][XRootD            ] [st-048-bb6fd221.cern.ch:1095] Handling response to kXR_pgread (handle: 0x00000000, offset: 4731697, size: 3010): user supplied buffer is too small for the received data.
[2022-07-03 15:06:20.135255 +0300][Dump   ][File              ] [0x900084b0@file://localhost/home/adrian/tmp/eccbaf72-2b76-518d-ad9d-cc88bdf752c4.meta4?xrdcl.requuid=eba86e06-2433-4a01-a5ca-ea2ae8ca5b94&xrdcl.unzip=QC_production.json] File state error encountered. Message kXR_pgread (handle: 0x00000000, offset: 4731697, size: 3010) returned with [ERROR] Invalid response
[2022-07-03 15:06:20.135269 +0300][Error  ][File              ] [0x900084b0@file://localhost/home/adrian/tmp/eccbaf72-2b76-518d-ad9d-cc88bdf752c4.meta4?xrdcl.requuid=eba86e06-2433-4a01-a5ca-ea2ae8ca5b94&xrdcl.unzip=QC_production.json] Fatal file state error. Message kXR_pgread (handle: 0x00000000, offset: 4731697, size: 3010) returned with [ERROR] Invalid response
[2022-07-03 15:06:20.135273 +0300][Dump   ][File              ] [0x900084b0@file://localhost/home/adrian/tmp/eccbaf72-2b76-518d-ad9d-cc88bdf752c4.meta4?xrdcl.requuid=eba86e06-2433-4a01-a5ca-ea2ae8ca5b94&xrdcl.unzip=QC_production.json] Failing message kXR_pgread (handle: 0x00000000, offset: 4731697, size: 3010) with [ERROR] Invalid response
[2022-07-03 15:06:20.135333 +0300][Debug  ][Utility           ] Unable read 0 bytes at 0 from file://localhost/home/adrian/tmp/eccbaf72-2b76-518d-ad9d-cc88bdf752c4.meta4?xrdcl.unzip=QC_production.json: [ERROR] Invalid response
[2022-07-03 15:06:20.200058 +0300][Error  ][JobMgr            ] The job manager is not running

full logs: https://asevcenc.web.cern.ch/asevcenc/xrootd_zip_small_buffer/ puzzling thing is that we have a similar case (same file stored in a zip) that is working (see dump logs for working vs non-working case) Let me know if you need any other information... Thanks a lot!!!

simonmichal commented 2 years ago

@adriansev : thanks for reporting this issue and for the reproducer! Just to let you know I was able to reproduce the problem and now it's under investigation.

simonmichal commented 2 years ago

@adriansev : I just pushed a patch: 91f9052b5a0303061895f9a6ef3a6b8acb3dabbe, could you give it a try?

simonmichal commented 2 years ago

@adriansev : the patch 91f9052b5a0303061895f9a6ef3a6b8acb3dabbe is incomplete and still needs some polishing, please stay tuned ;-)

simonmichal commented 2 years ago

@adriansev : I just pushed b35b6037d15dfe871a6e5d317c82f7fa86028fad, now it's ready to be tested ;-)

adriansev commented 2 years ago

@simonmichal sorry for tardiness, i was in holidays .. so, i can confirm that this is fixed! Thanks a lot!! L.E. tested with master b35b6037d