search

xrootd / xrootd

The XRootD central repository https://my.cdash.org/index.php?project=XRootD
http://xrootd.org
Other
147 stars 149 forks source link

Use `time_t` for times and timeouts in the client #2237

Closed amadio closed 2 months ago

amadio commented 2 months ago

Going via pull request to allow review, due to the many changes to the interfaces. Requires recompilation and maybe s/uint16_t/time_t/ in code using the XRootD client, but should be very straightforward to migrate. I have a similar patch using int instead of time_t for timeouts (that's what the XRootD server uses). Decided to use time_t as it's more future proof. See also man time_t(3type).

Fixes: #2236

amadio commented 2 months ago

@abh3 @apeters1971 @esindril Please let me know what you think. If there are no objections, I will push this into devel later to be part of XRootD 5.7.0. ROOT compiles just fine against XRootD with this patch. However, EOS will need changes. I will work on the migration on the EOS side so it's ready when XRootD is released.

amadio commented 2 months ago

For ROOT it should be fine, I compiled the master branch against this, no changes are needed. I also used the ROOT compiled against this to run the analysis grand challenge via XRootD. I noticed that ROOT 6.30.06 has a small issue with our CMake files (not related to this), but in the master branch of ROOT everything is fine. In any case, I will coordinate with Danilo on this.