search

xrrhythmsuk / xruk-player

A pattern-based drumming machine based on TypeScript, beatbox.js, Vue.js and Bootstrap.
https://player.xrrhythms.uk
GNU Affero General Public License v3.0
1 stars 0 forks source link

Reinstate tune filter #42

Closed timrog closed 1 year ago

timrog commented 1 year ago

fixes #27

github-actions[bot] commented 1 year ago

:eyes: A preview has been generated. Click here to view.

BirchBirchBirch commented 1 year ago

Looks great!

If I add category tags to individual breaks, could we also have them be filtered? (I realise this means adding rather than reinstating things)

timrog commented 1 year ago

I’m not sure how that would work because the breaks aren’t in that list. Does it filter tunes and breaks at the same time? If you filter by a tune tag, do the breaks get hidden that don’t have that tag?

BirchBirchBirch commented 1 year ago

That's what I mean, it isn't currently part of the filtering system but I think it would be really helpful if it was. (So a new band/player could see just the core tunes and breaks, and a more advanced band/player could prioritise which more involved breaks to learn based on if they're actually played much nationally.)

Currently, tunes aren't categorised separately from breaks (they don't have category tags at all currently) so they'll always appear with the song if it's there.

If having something like a list of tunes and breaks for each level to check against would be easier than trying to expand the existing category system then let's do that – I really appreciate you doing the harder part of the work and if we can make it less of a bother please just say!

timrog commented 1 year ago

Ok i’ll merge this and let’s tackle filtering patterns/breaks separately.