search

xrrhythmsuk / xruk-player

A pattern-based drumming machine based on TypeScript, beatbox.js, Vue.js and Bootstrap.
https://player.xrrhythms.uk
GNU Affero General Public License v3.0
1 stars 0 forks source link

Speed resets when viewing notation #43

Closed BirchBirchBirch closed 1 year ago

BirchBirchBirch commented 1 year ago

I've noticed that the speed resets to 100bpm for the notation view (as in, what comes up when you "tap on the pattern names below to see the notes"), including when the speed was set as part of the tune file.

For instance, Bhangra is hardcoded to 120bpm, but tapping "Tune" slows it down to 100bpm.

I think it would be helpful for user-set speed at the top level to persist in the notation view, but we should definitely fix the hardcoded speeds being ignored.

timrog commented 1 year ago

Ok. I’ll fix this and others soon. Bit snowed under at the moment but i’ll try and grab some time

BirchBirchBirch commented 1 year ago

Totally fair! Just making a note of it