search

xrrhythmsuk / xruk-player

A pattern-based drumming machine based on TypeScript, beatbox.js, Vue.js and Bootstrap.
https://player.xrrhythms.uk
GNU Affero General Public License v3.0
1 stars 0 forks source link

Playback settings #45

Closed timrog closed 1 year ago

timrog commented 1 year ago

Keeps the playback settings when navigating between pages. If changing tune, it resets the tempo to the tune default. Fixes #43

github-actions[bot] commented 1 year ago

:eyes: A preview has been generated. Click here to view.

timrog commented 1 year ago

@BirchBirchBirch This is Stolen@200bpm with the fixed tempo settings. Are you happy to go with this?

BirchBirchBirch commented 1 year ago

There seems to be a small issue where going straight to a spicy tempo tune (i.e. Bhangra/Jericho/Stolen) after first clicking "Listen" keeps the tempo at 100, though going to another tune and then coming back gets the right speed. (I tested it in a Private Browsing tab to reproduce the issue as otherwise it remembers.)

Other than that, looks great!

(My pull request on Stolen has a few more tweaks as well so probably worth putting it through anyway.)

BirchBirchBirch commented 1 year ago

Also, the example player song seems to keep the same place between different songs if you change tunes without pressing stop (e.g. listen to Funk example for 5 secs, click Karla without pressing stop, Karla example song is paused at 5 secs in). Probably better if it resets each tune change?

timrog commented 1 year ago

There seems to be a small issue where going straight to a spicy tempo tune (i.e. Bhangra/Jericho/Stolen) after first clicking "Listen" keeps the tempo at 100, though going to another tune and then coming back gets the right speed. (I tested it in a Private Browsing tab to reproduce the issue as otherwise it remembers.)

Other than that, looks great!

(My pull request on Stolen has a few more tweaks as well so probably worth putting it through anyway.)

OK good spot on both of those issues. They should be fixed now