search

xrrhythmsuk / xruk-player

A pattern-based drumming machine based on TypeScript, beatbox.js, Vue.js and Bootstrap.
https://player.xrrhythms.uk
GNU Affero General Public License v3.0
1 stars 0 forks source link

List built-in tunes by category instead of A-Z #71

Closed timrog closed 1 year ago

timrog commented 1 year ago

Fixes xrrhythmsuk/xruk-player#59

@BirchBirchBirch Please tweak categories as you see fit.

github-actions[bot] commented 1 year ago

:eyes: A preview has been generated. Click here to view.

BirchBirchBirch commented 1 year ago

The categories look great!

If possible it'd be good to have General Breaks display above "Core Tunes" (because they're not actually a tune) and have at least the core tunes display in the order:

Funk, Karla, Hedgehog, Samba Reggae, Bhangra

rather than alphabetically to suggest what order a new band should try them in.

timrog commented 1 year ago

OK done, but I thought it would be good to split General Breaks at some point in to Core, Common and New since it's getting quite large.

I've got no easy way of ordering tunes I'm afraid since they're now "discovered" from the tunes directory rather than being declared in one big file.

BirchBirchBirch commented 1 year ago

Oh right, not to worry about having them in a specific order within the categories, hopefully that'll be guidance enough.

That's just what I've been thinking about the breaks for a while, actually. I was thinking of having a Core Breaks and More Breaks page. (Probably still categorised above the songs?) I think ideally we'd have each page have descriptions and sound files (where the break has audio) interspersed instead of everything at the top. Also perhaps hide the silent breaks and whistle in "breaks"?

I can certainly split into Core and More to begin with, as I agree it's pretty busy!