search

xrrhythmsuk / xruk-player

A pattern-based drumming machine based on TypeScript, beatbox.js, Vue.js and Bootstrap.
https://player.xrrhythms.uk
GNU Affero General Public License v3.0
1 stars 0 forks source link

Split General Breaks into Core/More #72

Closed BirchBirchBirch closed 1 year ago

BirchBirchBirch commented 1 year ago

As discussed in #71

timrog commented 1 year ago

Good - we just need to fix it because it still has an empty General Breaks in the list for some reason. https://player.xrrhythms.uk/preview/BirchBirchBirch-gen-split/index.html#/listen

BirchBirchBirch commented 1 year ago

Hmm, that's odd. In my session it puts some custom breaks in there so maybe that's it? I'll have a look

I assume this wouldn't be going out before the categories UI change, but I'll see if I can get it to sort them first anyway

timrog commented 1 year ago

@BirchBirchBirch Is the aim with this to have breaks outside the category headings? Or something else?

Currently it's

Core tunes Core breaks ...

Common tunes More breaks ....

BirchBirchBirch commented 1 year ago

Oh right, no, that wasn't the plan 😅 I'll see if I can fix

The idea is

General breaks Core breaks More breaks

Core tunes ...

Better to have "general breaks" and "general" category than just "breaks", I think, as the songs have breaks as well