xrrhythmsuk / xruk-player

A pattern-based drumming machine based on TypeScript, beatbox.js, Vue.js and Bootstrap.
https://player.xrrhythms.uk
GNU Affero General Public License v3.0
1 stars 0 forks source link

Relabel new sharing tools for clarity? #74

Closed BirchBirchBirch closed 1 year ago

BirchBirchBirch commented 1 year ago

I've got feedback that people used to the previous system are confused that the "Share" option has moved.

After discussing it with them, we had the thought of getting rid of the "Export .wav"/".mp3" options and having the "Share" option include a tab for exporting the current song as a .wav or .mp3 in the popup. (Perhaps the tab could be "Export sound file" and then a radio button for .wav/.mp3 and a button to generate and download the file.)

On comparing with the RoR player, though, perhaps just moving the option back to its original position might be enough.

timrog commented 1 year ago

Hi Birch

I'm a bit confused. What's moved from where to where? Are you talking about the Share button at the top of custom pattern editor? There's a bunch of buttons missing from there so I'll fix that soon.

image

Export wav/mp3 are difficult to fit into the Share dialog works on a selection - you can't share a whole song as an Mp3 for example.

BirchBirchBirch commented 1 year ago

So this is on Compose, the dropdown menu that appears when you select Tools

Good to know those buttons are coming back though 😁

timrog commented 1 year ago

So this is on Compose, the dropdown menu that appears when you select Tools

Good to know those buttons are coming back though 😁

Well it's just moved 3 positions up in the menu compared to RoR. There aren't seriously people saying that's confusing? image image

BirchBirchBirch commented 1 year ago

It's true it's a small change, but that was the feedback I got. Perhaps wait to see if anyone else finds it a problem.

timrog commented 1 year ago

Reinstated Share button. Closing for now.

timrog commented 1 year ago

Reinstated Share button. Closing for now.