search

xrrhythmsuk / xruk-player

A pattern-based drumming machine based on TypeScript, beatbox.js, Vue.js and Bootstrap.
https://player.xrrhythms.uk
GNU Affero General Public License v3.0
1 stars 0 forks source link

Provide easy access to mnemonics #82

Closed timrog closed 9 months ago

timrog commented 10 months ago

For built-in tunes, we'd like to show the mnemonics without having to switch to PDF.

First prototype will be to enable switching the grid between notes and mnemonics view.

timrog commented 10 months ago

@BirchBirchBirch Can you have a look at this proof of concept for mnemonics and let me know what you think. There's a button on the toolbar now to switch to mnemonics view.

BirchBirchBirch commented 10 months ago

Amazing!

I'd suggest displaying the mnemonics together with the strokes (like I've got in the PDFs), or at least having the option to, so people can see what they're playing as well.

Also I don't know if it's just me but I think it's a bit wearing having all the text in italics (might look different if it was the strokes too?)

But yeah, brilliant!

BirchBirchBirch commented 10 months ago

Also if the mnemonic is cloned (e.g. for responses in breaks) perhaps it would be cleaner just to display the mnemonic once, maybe vertically centred or just once underneath the strokes (if you're doing that)