xrtlab / Validated-Avatar-Library-for-Inclusion-and-Diversity---VALID

MIT License
16 stars 1 forks source link

Fixed typos in pdf #2

Closed Zyrcant closed 9 months ago

vincentfretin commented 9 months ago

If I look at the two pdf versions, I see you changed Hispanic_F_3_Casual to MENA_F_3_Casual Hispanic_F_3_Busi to MENA_F_3_Busi Was it intentional? If you rename those, you probably want to rename the fbx files as well. Also what about Hispanic_F_2_Casual and Hispanic_F_2_Busi? Is this also a mistake in this case? Should those be renamed?

vincentfretin commented 9 months ago

FYI the pdf increased from 3.1MB to 7.8MB. The extracted images from my Python script with this pdf are of the same dimensions but are indeed bigger in file size. I'm not sure if you created the pdf differently this time, anyway that doesn't matter much. I'll keep the old pdf for my script, just renaming X_AIAN_F_2 to X_AIAN_F_1 that was the only remaining issue.

vincentfretin commented 9 months ago

I found 6 errors with the image text MENA_M2 and MENA_M3 are duplicated From the fbx files, it should be Hispanic_F2 and Hispanic_F3 for the the first and second lines in page 5. With those changes, I get all the 210 avatars with images with my script.

Zyrcant commented 9 months ago

My sincere apologies for the additional typos! I must have edited an old version of the PDF. Many thanks for catching these typos.

I just fixed it and double and triple checked this time for sure. The pdf should be fixed for real this time.

As for the size discrepancy-- I generated the pdf using Adobe Indesign, and I'm not quite sure what compression magic it does. In retrospect, I should have written a script to generate a markdown document of avatar previews, which would have been a lot faster and have less user error like typos... Perhaps it'll be something I work on in the near future, since we do have some new avatars planned for release in the upcoming months.

vincentfretin commented 9 months ago

I'm really sorry, but you forgot to change the gender on those three: Hispanic_M_2_Medi => Hispanic_F_2_Medi Hispanic_M_2_Milit => Hispanic_F_2_Milit Hispanic_M_2_Util => Hispanic_F_2_Util

Zyrcant commented 9 months ago

Fixed! :')