xrutayisire / react-js-cron

A React cron editor built with antd
https://xrutayisire.github.io/react-js-cron/?path=/docs/reactjs-cron--demo
MIT License
241 stars 105 forks source link

Why not support seconds #4

Closed yingpengsha closed 3 years ago

yingpengsha commented 3 years ago

Is your feature request related to a problem? Please describe. I'm always frustrated when I need seconds Selector. (hahaha

Describe the solution you'd like Add seconds Selector

Describe alternatives you've considered Unless there's a better component or I write another component on top of yours

Additional context I'll try to submit my code, maybe not right away, maybe just give up.

xrutayisire commented 3 years ago

Hi,

Thanks for the issue!

To simply answer the question, it's because I needed and decided to only support UNIX cron syntax and not Quartz cron syntax. cf: https://flylib.com/books/en/2.65.1/the_cron_expression_format.html

Seconds is not standard and it's part of the Quartz cron syntax. It could be an improvement of this library if it doesn't add too much complicated code to maintain.

I will think about it, to see how it can be done without breaking all the current system.

As I don't need to support Quartz syntax, I may not develop this right away so feel free for a PR 🙂