xrutayisire / react-js-cron

A React cron editor built with antd
https://xrutayisire.github.io/react-js-cron/?path=/docs/reactjs-cron--demo
MIT License
238 stars 105 forks source link

v3 issues #41

Closed vdineva closed 1 year ago

vdineva commented 1 year ago

Describe the bug Getting the following errors when upgrading to v5 of react-js-cron

Screenshots

App build Screenshot 2022-11-28 at 10 12 38

Unit tests Screenshot 2022-11-28 at 10 08 02

Versions (please complete the following information):

xrutayisire commented 1 year ago

Ouch! Thanks for the bug report!

I surely did something wrong with last v3.0.0 version for antd v5.

I will try to find a fix! Stay tuned!

xrutayisire commented 1 year ago

New release v3.0.1 is out! 🚀

Please test it and let me know if it's all good for you, I close the issue, but you can reopen it if you have any problem with the new build.

vdineva commented 1 year ago

@xrutayisire Thank you for the quick turnaround on this issue. I'm still seeing errors though with v3.0.1 of react-js-cron and v5.0.2 of antd:

Screenshot 2022-11-29 at 8 57 31

xrutayisire commented 1 year ago

So strange, I created a small code sandbox to check the new release and it's working with v3.0.1 but not with old v3.0.0.

Link: https://codesandbox.io/s/test-release-react-js-cron-814ylc?file=/src/App.tsx

Can you give me a reproducible repository or a code sandbox so I can understand how this happen?

vdineva commented 1 year ago

Interesting - one thing I noticed is that the codesandbox uses v18 of React and we're locked in at v17 - maybe that's what it is? Will try to take a deeper look today

xrutayisire commented 1 year ago

Tested with react 17 and it's working, with antd 4.23.0 (minimal supported version) or v5.0.2

Link: https://codesandbox.io/s/test-release-react-js-cron-min-versions-6bb0cz?file=/src/App.tsx

I will update info about minimal required version because react 16.8.0 is too old now for me to support.

xrutayisire commented 1 year ago

Without any activity, I'm closing this thread. Don't hesitate to reply again here with a reproducible repo and I reopen the issue.