search

xrutayisire / react-js-cron

A React cron editor built with antd
https://xrutayisire.github.io/react-js-cron/?path=/docs/reactjs-cron--demo
MIT License
238 stars 105 forks source link

export convertor #45

Closed useafterfree closed 1 year ago

useafterfree commented 1 year ago

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

codecov[bot] commented 1 year ago

Codecov Report

Base: 84.75% // Head: 84.75% // No change to project coverage :thumbsup:

Coverage data is based on head (343c2d2) compared to base (242915a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #45 +/- ## ======================================= Coverage 84.75% 84.75% ======================================= Files 12 12 Lines 492 492 Branches 197 197 ======================================= Hits 417 417 Misses 12 12 Partials 63 63 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Xavier+Rutayisire). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Xavier+Rutayisire)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

xrutayisire commented 1 year ago

Thanks for the PR and the idea.

What I would like if we open the convertor is to document it in the README. What I mean is all exported functions should be centralized with a comment, so everyone knows what kind of function you can use.

Moreover, I think a little refactoring can be nice if we do this to convert exported functions that have too many parameters with object.

xrutayisire commented 1 year ago

Please correct linting so a merge is possible